Add missing WindowOperator#isBlocked method #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@findepi spill can be triggered by window operator itself when flipping memory without explicit revoke signal |
findepi
approved these changes
Mar 14, 2019
| return outputPages.getBlockedFuture(); | ||
| } | ||
|
|
||
| return NOT_BLOCKED; |
There was a problem hiding this comment.
I regret that you cannot simply return outputPages.getBlockedFuture().
add a comment:
// We can block e.g. because of self-triggered spill
if (outputPages.isBlocked()) {
WindowOperator can block when spilling, therefore it needs to explicitly support isBlocked method.
sopel39
force-pushed
the
ks/add_is_block_window
branch
from
79807fe
to
1dbd215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WindowOperator can block when spilling,
therefore it needs to explicitly support isBlocked
method.